fix: keep SGS hall fallback metadata preview-only

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
lyf
2026-06-30 01:12:59 +08:00
parent c06d309e08
commit 4a8284a29d
2 changed files with 25 additions and 23 deletions

View File

@@ -1,10 +1,10 @@
# Task 2 Report
Status: DONE_WITH_CONCERNS
Status: DONE
Files changed:
- `src/data/adapters/sgsSdkGuideAdapter.ts`
- `src/domain/museum.ts`
- `.superpowers/sdd/task-2-report.md`
Commands run:
- `node scripts/check-sgs-hall-poi-adapter.mjs`
@@ -12,16 +12,12 @@ Commands run:
- `pnpm type-check`
- Output summary: `vue-tsc --noEmit` completed successfully.
Commits created:
- `08a6bcb` in implementer worktree: `feat: expand SGS hall POI adaptation`
- Main workspace integrated manually because cherry-pick was blocked by existing local changes to the same files.
Commit:
- Pending in current worktree at report update time.
Self-review notes:
- Adapter now includes public exhibition-space whitelist and keyword checks.
- `toMuseumHallPoisFromSgs` now supports entrance anchors, space-center fallback, standalone space fallback, and diagnostics helper.
- Main integration preserves stronger Task 1 semantics approved by user: `backend-sgs-sdk-hall-entrance` requires both entrance coordinates and route node, and later real entrance anchors can upgrade a space-center POI.
- `src/domain/museum.ts` already had/keeps typed hall fields (`MuseumPoiKind`, `MuseumPoiEntrance`, hall/source fields, preview fields) required by adapter output.
Notes:
- POI-level `sourcePlaceId` now remains unset for space-center fallback halls; entrance-specific `sourcePlaceId`/`routeNodeId` stay on `entrances` until a route-capable entrance upgrades the POI.
- Space-center fallback halls now use matched-space floor metadata; route-capable entrance upgrades replace POI floor metadata with entrance floor metadata and set `sourceConfidence` to `backend-sgs-sdk-hall-entrance`.
Concerns:
- Manual integration was required because the main workspace already had overlapping uncommitted changes in adapter/domain files.
- Task 3 will add repository diagnostics consumption of `createSgsHallPoiDiagnostics`.
- The targeted smoke script is a lightweight regression harness, not a full test runner.