fix: harden SGS hall POI matching diagnostics
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -4,20 +4,22 @@ Status: DONE
|
||||
|
||||
Files changed:
|
||||
- `src/data/adapters/sgsSdkGuideAdapter.ts`
|
||||
- `scripts/check-sgs-hall-poi-adapter.mjs`
|
||||
- `.superpowers/sdd/task-2-report.md`
|
||||
|
||||
Commands run:
|
||||
- `node scripts/check-sgs-hall-poi-adapter.mjs`
|
||||
- Output: `SGS hall POI adapter smoke check passed`
|
||||
- Output: command completed successfully with no stdout; all assertions passed.
|
||||
- `pnpm type-check`
|
||||
- Output summary: `vue-tsc --noEmit` completed successfully.
|
||||
- Output summary: failed in the worktree because `vue-tsc` was not resolvable there (`node_modules` / local bin unavailable in the isolated worktree).
|
||||
|
||||
Commit:
|
||||
- `18385be` `fix: keep SGS hall fallback metadata preview-only`
|
||||
- Pending
|
||||
|
||||
Notes:
|
||||
- POI-level `sourcePlaceId` now remains unset for space-center fallback halls; entrance-specific `sourcePlaceId`/`routeNodeId` stay on `entrances` until a route-capable entrance upgrades the POI.
|
||||
- Space-center fallback halls now use matched-space floor metadata; route-capable entrance upgrades replace POI floor metadata with entrance floor metadata and set `sourceConfidence` to `backend-sgs-sdk-hall-entrance`.
|
||||
- Hall-space matching now ranks candidates by specificity: exact normalized name match first, then longest normalized overlapping space name.
|
||||
- Place-only fallback hall IDs now include floor identity, preventing cross-floor collisions for same-named halls.
|
||||
- `skippedSpaceCount` now checks whether each eligible space has its canonical `hall-{space.id}` POI, so place-only halls no longer distort diagnostics.
|
||||
|
||||
Concerns:
|
||||
- The targeted smoke script is a lightweight regression harness, not a full test runner.
|
||||
- `pnpm type-check` could not complete inside the isolated worktree because the local `vue-tsc` binary was unavailable there.
|
||||
|
||||
Reference in New Issue
Block a user