lyf/frontend-miniapp
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

test: refine SGS hall POI source semantics

Browse Source 
Fix semantic gaps in smoke script:
1. backend-sgs-sdk-hall-entrance now requires BOTH entrance position AND nodeId
2. Added fixture: place with coordinates but no nodeId matches space center
3. Added fixture: normalized names (spacing/brackets) match spaces correctly
4. Maintained unmatched exhibition space fallback coverage

All new fixtures consolidate into existing POIs, keeping 7 unique halls.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
lyf
2026-06-30 00:07:04 +08:00
parent 16a5a0d1bc
commit c2800bb277
2 changed files with 49 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.superpowers/sdd/task-1-report.md
View File

@@ -17,16 +17,26 @@ Output summary:
5. Unmatched exhibition space with center emits fallback POI
6. Entrance with missing coordinates falls back to matched space.center
7. Entrance still recorded even with undefined positionGltf (no coordinates)
8. **Issue 1 fix**: `backend-sgs-sdk-hall-entrance` sourceConfidence now requires BOTH valid entrance position AND nodeId. Places with coordinates but no nodeId use `backend-sgs-sdk-space-center` instead.
9. **Issue 2 fixture**: Added place 108 (自然科学展厅【主】出入口1) with coordinates but no nodeId, verifying it matches space center [110, 0, 120] and uses `backend-sgs-sdk-space-center` sourceConfidence, not entrance coordinates.
10. **Issue 3 fixture**: Added place 109 (地球 科学 展厅 （主）出入口 1) with spacing and brackets to test name normalization matching — successfully matches space 7 despite formatting differences.
11. **Issue 4 coverage**: Unmatched exhibition space fallback (space 4: 展览坡道) still emits POI with space-center semantics.
Commits created:
- `test: assert SGS hall POI route semantics`
- `test: refine SGS hall POI source semantics`
Self-review notes:
- The script is standalone Node coverage for the intended adapter rules because this repository has no configured test runner.
- The production adapter implementation is covered by Task 2 in the plan.
- The semantic gap fix ensures sourceConfidence correctly requires BOTH position and nodeId for hall-entrance classification
- Fixture 108 validates the space-center fallback for entries with coordinates but no routing identity
- Fixture 109 demonstrates that name normalization handles real-world formatting variations (spacing, brackets, punctuation)
- All fixtures consolidate into existing POIs, maintaining clean POI count (7) while improving semantic coverage
- The script is standalone Node coverage for the intended adapter rules because this repository has no configured test runner
- The production adapter implementation is covered by Task 2 in the plan
- Fixtures now include:
- Space 8 (古生物展厅) with entrance 105 that has nodeId n105 for backend-sgs-sdk-hall-entrance assertion
- Place 107 (自然科学展厅 出入口) without nodeId to assert space-center semantics when entrance lacks routing identity
- Place 108 (自然科学展厅【主】出入口1) with coordinates but no nodeId verifying space.center position precedence
- Place 109 (地球 科学 展厅 （主）出入口 1) with spacing/brackets demonstrating name matching robustness
- Name uniqueness validation prevents silent duplicate masking
Concerns: