From ec6f6568320d04952f919a38ef8bbff0c782e206 Mon Sep 17 00:00:00 2001 From: lyf <2514544224@qq.com> Date: Mon, 29 Jun 2026 23:37:34 +0800 Subject: [PATCH] test: clean SGS hall POI smoke script --- .superpowers/sdd/task-1-report.md | 21 +++++++++++++++++++++ scripts/check-sgs-hall-poi-adapter.mjs | 2 +- 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 .superpowers/sdd/task-1-report.md diff --git a/.superpowers/sdd/task-1-report.md b/.superpowers/sdd/task-1-report.md new file mode 100644 index 0000000..e606bea --- /dev/null +++ b/.superpowers/sdd/task-1-report.md @@ -0,0 +1,21 @@ +# Task 1 Report + +Status: DONE + +Files changed: +- `scripts/check-sgs-hall-poi-adapter.mjs` + +Commands run: +- `node scripts/check-sgs-hall-poi-adapter.mjs` +- Output summary: smoke script passed. Current script validates whitelist enforcement, fallback POI emission for unmatched public exhibition spaces, entrance coordinate preference, space-center fallback when entrance coordinates are missing, and sourceConfidence semantics. + +Commits created: +- `3f049f2` test: cover SGS hall POI display rules +- `5478986` test: strengthen SGS hall POI smoke coverage + +Self-review notes: +- The script is standalone Node coverage for the intended adapter rules because this repository has no configured test runner. +- The production adapter implementation is covered by Task 2 in the plan. + +Concerns: +- None. diff --git a/scripts/check-sgs-hall-poi-adapter.mjs b/scripts/check-sgs-hall-poi-adapter.mjs index 9932908..39ececd 100644 --- a/scripts/check-sgs-hall-poi-adapter.mjs +++ b/scripts/check-sgs-hall-poi-adapter.mjs @@ -136,7 +136,7 @@ const toHallPois = (spaces, navigablePlaces, fallbackFloorId) => { }) }) - hallSpaces.forEach((space, index) => { + hallSpaces.forEach((space) => { const poiId = `hall-${space.id}` if (halls.has(poiId)) return const position = normalizeSpaceCenter(space)