1.5 KiB
1.5 KiB
Task 1 Report
Status: DONE
Files changed:
scripts/check-sgs-hall-poi-adapter.mjs
Commands run:
node scripts/check-sgs-hall-poi-adapter.mjs
Output summary:
- Smoke script passed. Script now validates:
- Finding 1: entrance-derived sourceConfidence branch — entrance-backed halls with nodeId must be
backend-sgs-sdk-hall-entrance - Finding 2: enforce entrance/reachable-node semantics — entrances without nodeId that match spaces use space-center sourceConfidence, not hall-entrance
- Finding 3: avoid hiding duplicate names via Map-by-name only — added assertion that result names are unique, indexed by both name and id for duplicate detection
- Whitelist enforcement prevents unrelated types
- Unmatched exhibition space with center emits fallback POI
- Entrance with missing coordinates falls back to matched space.center
- Entrance still recorded even with undefined positionGltf (no coordinates)
- Finding 1: entrance-derived sourceConfidence branch — entrance-backed halls with nodeId must be
Commits created:
test: assert SGS hall POI route semantics
Self-review notes:
- The script is standalone Node coverage for the intended adapter rules because this repository has no configured test runner.
- The production adapter implementation is covered by Task 2 in the plan.
- Fixtures now include:
- Space 8 (古生物展厅) with entrance 105 that has nodeId n105 for backend-sgs-sdk-hall-entrance assertion
- Place 107 (自然科学展厅 出入口) without nodeId to assert space-center semantics when entrance lacks routing identity
- Name uniqueness validation prevents silent duplicate masking
Concerns:
- None.