test: clean SGS hall POI smoke script
This commit is contained in:
21
.superpowers/sdd/task-1-report.md
Normal file
21
.superpowers/sdd/task-1-report.md
Normal file
@@ -0,0 +1,21 @@
|
||||
# Task 1 Report
|
||||
|
||||
Status: DONE
|
||||
|
||||
Files changed:
|
||||
- `scripts/check-sgs-hall-poi-adapter.mjs`
|
||||
|
||||
Commands run:
|
||||
- `node scripts/check-sgs-hall-poi-adapter.mjs`
|
||||
- Output summary: smoke script passed. Current script validates whitelist enforcement, fallback POI emission for unmatched public exhibition spaces, entrance coordinate preference, space-center fallback when entrance coordinates are missing, and sourceConfidence semantics.
|
||||
|
||||
Commits created:
|
||||
- `3f049f2` test: cover SGS hall POI display rules
|
||||
- `5478986` test: strengthen SGS hall POI smoke coverage
|
||||
|
||||
Self-review notes:
|
||||
- The script is standalone Node coverage for the intended adapter rules because this repository has no configured test runner.
|
||||
- The production adapter implementation is covered by Task 2 in the plan.
|
||||
|
||||
Concerns:
|
||||
- None.
|
||||
@@ -136,7 +136,7 @@ const toHallPois = (spaces, navigablePlaces, fallbackFloorId) => {
|
||||
})
|
||||
})
|
||||
|
||||
hallSpaces.forEach((space, index) => {
|
||||
hallSpaces.forEach((space) => {
|
||||
const poiId = `hall-${space.id}`
|
||||
if (halls.has(poiId)) return
|
||||
const position = normalizeSpaceCenter(space)
|
||||
|
||||
Reference in New Issue
Block a user